Skip to content

fix: only run workflow build and deploy image action if scheduled or auto run if on…#4214

Merged
aglinxinyuan merged 6 commits intoapache:mainfrom
Ma77Ball:fix/BuildPushImageAlwaysRuns
Apr 17, 2026
Merged

fix: only run workflow build and deploy image action if scheduled or auto run if on…#4214
aglinxinyuan merged 6 commits intoapache:mainfrom
Ma77Ball:fix/BuildPushImageAlwaysRuns

Conversation

@Ma77Ball
Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

This PR fixes the CI workflow so the “build and push images” job does not run on every contributor’s branch. The job is now gated with a job-level condition:

if: github.event_name != 'schedule' || github.repository == 'apache/texera'

This ensures the job runs for normal (non-scheduled) events, and for scheduled runs only when the workflow is running in the upstream apache/texera repository.

Any related issues, documentation, discussions?

N/A

How was this PR tested?

CI workflow change only. Verified the condition restricts scheduled runs to apache/texera while allowing non-scheduled events to proceed as before.

Was this PR authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added fix ci changes related to CI labels Feb 14, 2026
@Ma77Ball
Copy link
Copy Markdown
Contributor Author

@bobbai00 or @kunwp1, can you review the following PR?

@Ma77Ball Ma77Ball changed the title added job parameter to only run action if scheduled or auto run if on… fix: only run workflow build and deploy image action if scheduled or auto run if on… Feb 14, 2026
@chenlica chenlica requested review from bobbai00 and kunwp1 February 15, 2026 05:21
@chenlica
Copy link
Copy Markdown
Contributor

@bobbai00 @kunwp1 : please review this PR.

Copy link
Copy Markdown
Contributor

@kunwp1 kunwp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chenlica
Copy link
Copy Markdown
Contributor

@bobbai00 Please review it.

@Ma77Ball
Copy link
Copy Markdown
Contributor Author

Ma77Ball commented Apr 9, 2026

@bobbai00 I updated the branch. Please let me know if any changes are needed.

@aglinxinyuan aglinxinyuan enabled auto-merge (squash) April 17, 2026 06:15
@aglinxinyuan aglinxinyuan merged commit 2b62539 into apache:main Apr 17, 2026
11 checks passed
bobbai00 pushed a commit to bobbai00/texera that referenced this pull request Apr 18, 2026
…auto run if on… (apache#4214)

<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to
Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
  2. Ensure you have added or run the appropriate tests for your PR
  3. If the PR is work in progress, mark it a draft on GitHub.
  4. Please write your PR title to summarize what this PR proposes, we 
    are following Conventional Commits style for PR titles as well.
  5. Be sure to keep the PR description updated to reflect all changes.
-->

### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this
section
is to outline the changes. Here are some tips for you:
  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, you can clarify why it is a bug.
  3. If it is a refactoring, clarify what has been changed.
  3. It would be helpful to include a before-and-after comparison using 
     screenshots or GIFs.
  4. Please consider writing useful notes for better and faster reviews.
-->
This PR fixes the CI workflow so the “build and push images” job does
not run on every contributor’s branch. The job is now gated with a
job-level condition:

if: github.event_name != 'schedule' || github.repository ==
'apache/texera'

This ensures the job runs for normal (non-scheduled) events, and for
scheduled runs only when the workflow is running in the upstream
apache/texera repository.

### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned
already.
1. If this PR fixes an issue, please include `Fixes apache#1234`, `Resolves
apache#1234`
or `Closes apache#1234`. If it is only related, simply mention the issue
number.
  2. If there is design documentation, please add the link.
  3. If there is a discussion in the mailing list, please add the link.
-->
N/A

### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if
the PR
is tested with existing test cases. Make sure to include/update test
cases that
check the changes thoroughly including negative and positive cases if
possible.
If it was tested in a way different from regular unit tests, please
clarify how
you tested step by step, ideally copy and paste-able, so that other
reviewers can
test and check, and descendants can verify in the future. If tests were
not added,
please describe why they were not added and/or why it was difficult to
add.
-->
CI workflow change only. Verified the condition restricts scheduled runs
to apache/texera while allowing non-scheduled events to proceed as
before.

### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
PR,
please include the phrase: 'Generated-by: ' followed by the name of the
tool
and its version. If no, write 'No'. 
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for
details.
-->
No

Co-authored-by: Chen Li <chenli@gmail.com>
Co-authored-by: Xinyuan Lin <xinyual3@uci.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants